Skip to content

Update Person.java #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yann-gael wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Person.java #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sdm/src/java/association/Person.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@

public class Person
{
int count;
Head head;
Torso torso;
Limbs limbs;
Person(int headCount, int torsoCount, int limbsCount)
int count; // Dead code, use your IDE to identify and remove dead code.
Head head; // Multiple instances rather than one instance with a count.
Torso torso; // Same
Limbs limbs; // Same
Person(int headCount, int torsoCount, int limbsCount) // Why not public? Also remove the "long" list of int parameters
{
head = new Head(headCount);
torso = new Torso(torsoCount);
limbs = new Limbs(limbsCount);
}
void showAll()
{
System.out.println("New person created.");
System.out.println("New person created."); // Remove
head.showAll();
torso.showAll();
limbs.showAll();
Expand Down