Skip to content

[python] resolve MacOS CI OOM failure#4148

Merged
bkmartinjr merged 52 commits into
mainfrom
bkm/chase-macos-segv
Jun 30, 2025
Merged

[python] resolve MacOS CI OOM failure#4148
bkmartinjr merged 52 commits into
mainfrom
bkm/chase-macos-segv

Conversation

@bkmartinjr

@bkmartinjr bkmartinjr commented Jun 26, 2025

Copy link
Copy Markdown
Member

Fixes SOMA-335

There has been a long-standing crash in the MacOS CI. The root cause was an OOM in tests caused by the 7GiB runner config. It occurred primarily in MacOS because max resident memory usage in MacOS is higher than Linux.

As part of this, also found a bug in ExperimentAxisQuery.to_anndata obsm/varm reading, where it would incorrectly determine the shape of the second (feature) dimension (this would only occur in cases where a feature had only zeros, and was therefore not written as part of the sparse array).

Changes:

  • added a SOMATileDBContext fixture in the tests, with memory budget set to fairly small values when in the CI environment.
  • used the new fixture in the tests which create memory pressure
  • fixed aforementioned bug in ExperimentAxisQuery._read_inner_ndarray
  • fixed formatting in several GHA yaml files

@codecov

codecov Bot commented Jun 26, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (606197d) to head (5cbba58).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4148       +/-   ##
===========================================
+ Coverage   66.25%   89.47%   +23.21%     
===========================================
  Files         161       60      -101     
  Lines       19842     7165    -12677     
  Branches     1238        0     -1238     
===========================================
- Hits        13147     6411     -6736     
+ Misses       6287      754     -5533     
+ Partials      408        0      -408     
Flag Coverage Δ
libtiledbsoma ?
python 89.47% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.47% <100.00%> (-0.03%) ⬇️
libtiledbsoma ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bkmartinjr bkmartinjr changed the title [python] WIP [python] resolve MacOS CI OOM failure Jun 28, 2025
@bkmartinjr bkmartinjr marked this pull request as ready for review June 28, 2025 22:24
@bkmartinjr bkmartinjr requested review from jp-dark and ktsitsi June 28, 2025 22:24
@bkmartinjr bkmartinjr merged commit fcc919a into main Jun 30, 2025
18 checks passed
@bkmartinjr bkmartinjr deleted the bkm/chase-macos-segv branch June 30, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants