[c++] Change Count operation column name#4459
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4459 +/- ##
==========================================
- Coverage 85.27% 85.27% -0.01%
==========================================
Files 136 136
Lines 21266 21266
==========================================
- Hits 18135 18134 -1
- Misses 3131 3132 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jp-dark
requested changes
May 5, 2026
jp-dark
left a comment
Collaborator
There was a problem hiding this comment.
Fix looks good, but could you add a test that repros the bug in SOMA-938 as well?
Collaborator
Author
|
Added test. With the chosen name a user can't create a column with name anyway due to prior constraints in the creation code path. |
jp-dark
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Resolves #4442
Changes:
Provide a different uncommon name for the
Countoperation to avoid conflicts with array column namesNotes for Reviewer: