Conversation
johnkerl
force-pushed
the
kerl/nnz
branch
2 times, most recently
from
7345ddc to
8cfdadc
Compare
johnkerl
force-pushed
the
kerl/yt-hack
branch
from
511a96c to
6b6ac4e
Compare
johnkerl
force-pushed
the
kerl/nnz
branch
2 times, most recently
from
bece55e to
e1ad705
Compare
eddelbuettel
left a comment
eddelbuettel
left a comment
Contributor
There was a problem hiding this comment.
I don't speak Python well enough to be of real help here so I abstain. Thanks for thinking of me though.
gspowley
previously requested changes
Oct 21, 2022
johnkerl
dismissed
gspowley’s stale review
took out bits from #400 that didn't belong here
gspowley
approved these changes
Oct 21, 2022
2 tasks
johnkerl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #431 and #410