Open
Conversation
Member
sbleon
commented
Sep 22, 2025
- Throw an error if misconfigured instead of logging. Also remove a maybe-lying comment.
- Replace the cache file after scanning for objects instead of blowing it away first thing
…be-lying comment.
…it away first thing This should make resets interfere less with other concurrent requests
Rodel30
requested changes
Sep 22, 2025
Member
Rodel30
left a comment
There was a problem hiding this comment.
Good idea, just one little thing I think should be different 🙃
| <cfset this.scanForObjects()> | ||
|
|
||
| <cfif arguments.useCacheFile> | ||
| <cfif arguments.useCacheFile or arguments.deleteCacheFile> |
Member
There was a problem hiding this comment.
While I think the use case likely doesn't really exist, given the names of the arguments I think it may be better to have this as:
<cfif arguments.useCacheFile>
//Writing the cache file, as is currently happening
<cfelseif arguments.deleteCacheFile>
//delete the cache file without writing a new one, effectively moving the delete command that used to be up top down here
<cfelse>
//do nothing, as is currently happening
This preserves the previous effective functionality, while still having the benefit of not having a missing cache file while the new copy is being constructed.
Member
Author
There was a problem hiding this comment.
I'm intentionally changing the meaning of deleteCacheFile to be "replace cache file". Of the few known apps (2?) that use this library, I don't think there are any use cases that would just want to delete file and not replace it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.