refactoring and typing

[noskill]

No description provided.

[noskill]

We can also remove "Pipe" from class names in pipes.py It is clear anyway that in module pipes we have some pipes

[noskill]

I removed Pipe from class names as redundant. It still very clear from Prompt2Im what class is doing without "Pipe".

other renames:
CIm2ImPipe -> ControlNet2Im
fimage -> img_path
fname -> img_path
csalem -> default_cs

[Necr0x0Der]

I removed Pipe from class names as redundant. It still very clear from Prompt2Im what class is doing without "Pipe".

This is a weak argument to rename all the classes introducing breaking changes. In diffusers, many classes start with "StableDiffusion" and end with "Pipeline", although this also is obvious. Since different points of view on naming exist, and no approach is unconditionally supreme, introducing such breaking changes without necessity is simply a bad practice. It should also be added that other classes are envisioned in metafusion, which will not be Pipes, so it makes sense to distinguish them by naming convention.

default_cs

This is a bad name, because it is obvious that these are default values, but it is not obvious what "cs" is. If renaming is introduced, it should really be superior (and hopefully optimal).

ControlNet2Im

This is a bad name, since there is no sense in transforming ControlNet to Im. And why ControlNet is fully written, while Im is not? It is also important to make naming of all Pipe classes consistent, while this renaming contradicts to both Im2ImPipe and Cond2ImPipe.

[Necr0x0Der]

See comments above.

[noskill]

default_cs is superior to cscalem, because what "calem" or "alem" even means?

Other variants I can suggest:
control_scales or just cscales - feels the same as gscale we use for guidance scale

[Necr0x0Der]

default_cs is superior to cscalem, because what "calem" or "alem" even means?

"scale" means scale. Thus, default_cs is not precisely superior. And it is also not the question if it is superior or not, but if you are doing such refactoring, you should be sure that it will not be done once again right away.

Other variants I can suggest: control_scales or just cscales - feels the same as gscale we use for guidance scale

I don't have strong preferences over cscales, default_control_scales, control_scales by themselves. The only thing that the naming style should be uniform at least within components or separate files of the library.

[noskill]

"scale" means scale.

Yes, but what scalem means?

[Necr0x0Der]

Yes, but what scalem means?

I don't even remember. It is a temporary name.