feat: add missing SirixDB REST API endpoints#26
Open
JohannesLichtenberger wants to merge 1 commit intomasterfrom
Open
feat: add missing SirixDB REST API endpoints#26JohannesLichtenberger wants to merge 1 commit intomasterfrom
JohannesLichtenberger wants to merge 1 commit intomasterfrom
Conversation
Add path summary endpoint, batch resource creation, and extend history, create, update, read, and query methods with additional server parameters (commit messages, timestamps, pagination controls, query plans). Fix async_client get_database_info missing Accept header and incorrect lastTopLevelNodeKey parameter name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept: application/jsonheader toAsyncClient.get_database_info()(matching sync client)lastTopLevelNodeKeyparam tostartNodeKeyin_build_read_params()GET /:db/:resource/pathSummary) with optional revision paramPOST /:dbmultipart) viaDatabase.create_resources()history()withrevisions,start_revision,end_revisionparamscreate()andupdate()withcommit_message,commit_timestampparamsread()andread_with_metadata()withnumber_of_nodes,max_children,pretty_print,start_node_keyparamsquery()(on bothSirixandResource) withcommit_message,commit_timestamp,plan,plan_stageparamsPathSummaryNodeTypedDict added and exportedAll new parameters default to
None— no existing call sites break.Test plan