Bump vendored compare bundle: pagexray cookie Domain= newline fix#262
Merged
Conversation
Picks up the upstream pagexray fix that stops the next cookie's name leaking into a Domain= attribute when a HAR concatenates multiple Set-Cookie response headers into one value joined by '\n'. Before this, compare's cookie list rendered domains like ".scorecardresearch.com\nUIDR=1453756870" — same string sitting in pagexray's output, just made visible by the UI. Also rolls forward the rest of the pagexray refresh — the same 5.0.0 cut that landed for unrelated bug-fix and tooling reasons (HTTP/3 detection, case-insensitive Cache-Control directives, the missingCompression over-count fix, case-insensitive Domain= matching that surfaced the newline corruption in the first place). The vendored bundle shrinks from ~28 KB to ~17 KB thanks to pagexray's switch from uglify-es to terser and the modernised Babel preset-env defaults. Co-authored-by: Claude Opus 4.7 (1M context) noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the upstream pagexray fix that stops the next cookie's name leaking into a Domain= attribute when a HAR concatenates multiple
Set-Cookie response headers into one value joined by '\n'. Before this, compare's cookie list rendered domains like
".scorecardresearch.com\nUIDR=1453756870" — same string sitting in pagexray's output, just made visible by the UI.
Also rolls forward the rest of the pagexray refresh — the same 5.0.0 cut that landed for unrelated bug-fix and tooling reasons (HTTP/3
detection, case-insensitive Cache-Control directives, the missingCompression over-count fix, case-insensitive Domain= matching that surfaced
the newline corruption in the first place). The vendored bundle shrinks from ~28 KB to ~17 KB thanks to pagexray's switch from uglify-es to
terser and the modernised Babel preset-env defaults.
Co-authored-by: Claude Opus 4.7 (1M context) noreply@anthropic.com