Switch /admin Recent failures to a DB-backed read - #268
Merged
Conversation
The failures table read from Bull's retained-failures list, which only sees what the testrunner itself throws and never decays. The result was a 24 h health pill that could say "1 failed" above an empty table — because the actual failure was a non-zero sitespeed.io exit on the result queue, or a queue-down at submit time, neither of which Bull records. v4.0.0 made the DB authoritative for those modes via failed_reason and finished_date; this picks up that work. The Retry button goes with the switch. DB rows don't carry a Bull job id, and the rerun icon on /search already covers the same need from a page the operator is more likely to be on anyway. Co-authored-by: Claude Sonnet 4.6 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failures table read from Bull's retained-failures list, which only
sees what the testrunner itself throws and never decays. The result was
a 24 h health pill that could say "1 failed" above an empty table —
because the actual failure was a non-zero sitespeed.io exit on the
result queue, or a queue-down at submit time, neither of which Bull
records. v4.0.0 made the DB authoritative for those modes via
failed_reason and finished_date; this picks up that work.
The Retry button goes with the switch. DB rows don't carry a Bull job
id, and the rerun icon on /search already covers the same need from a
page the operator is more likely to be on anyway.
Co-authored-by: Claude Sonnet 4.6 noreply@anthropic.com