Render screenshots, filmstrip and video on compare across origins#269
Merged
Conversation
The compare page loads its HAR-derived screenshots, filmstrip frames and video from whatever sitespeed.io result server originally produced the HAR — typically a separate origin from the one running onlinetest itself. The helmet CSP only allowed 'self' for images and (implicitly, via default-src) for video, so those slots rendered empty whenever the HAR pointed at a different host. Relax img-src and add a media-src that allow any HTTPS origin so the compare view actually shows what the HAR captured. Co-authored-by: Claude noreply@anthropic.co
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compare page loads its HAR-derived screenshots, filmstrip frames
and video from whatever sitespeed.io result server originally produced
the HAR — typically a separate origin from the one running onlinetest
itself. The helmet CSP only allowed 'self' for images and (implicitly,
via default-src) for video, so those slots rendered empty whenever the
HAR pointed at a different host. Relax img-src and add a media-src
that allow any HTTPS origin so the compare view actually shows what the
HAR captured.
Co-authored-by: Claude noreply@anthropic.co