feat(sign): enhance signing process with error handling and response …#210
Open
elias96 wants to merge 1 commit into
Open
feat(sign): enhance signing process with error handling and response …#210elias96 wants to merge 1 commit into
elias96 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the signing CLI flow in sitevision-scripts to centralize signing-response handling, improve user-facing error reporting, and validate that the signing endpoint returns a downloadable artifact instead of an unexpected JSON payload.
Changes:
- Extracts signing-specific helpers for error-code parsing, failure messaging, and writing the signed zip.
- Updates
sign.jsto use the new helpers and add explicit handling for non-OK responses, JSON responses, and missing response bodies. - Slightly cleans up the prompt setup in the signing script.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
packages/sitevision-scripts/scripts/sign.js |
Reworks the main signing flow to use helper-based response validation and failure reporting. |
packages/sitevision-scripts/scripts/util/signHelper.js |
Adds reusable helpers for signing error-code extraction, failure messaging, and streaming the signed zip to disk. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| const ERROR_MESSAGES = { | ||
| CERTIFICATE_NOT_FOUND: (certificateLabel = 'default') => { | ||
| return `Certificate "${certificateLabel}" was not found.`; |
Comment on lines
+98
to
+105
| if (!response.body) { | ||
| printSigningFailure({ | ||
| status: response.status, | ||
| statusText: response.statusText, | ||
| code: 'EMPTY_RESPONSE', | ||
| certificateName: answers.certificateName, | ||
| }); | ||
| return; |
Comment on lines
+84
to
+93
| await new Promise((resolve, reject) => { | ||
| const writer = fs.createWriteStream(signedFileNameAndPath, { | ||
| autoClose: true, | ||
| }); | ||
|
|
||
| response.body.once('error', reject); | ||
| writer.once('error', reject); | ||
| writer.once('finish', resolve); | ||
| response.body.pipe(writer); | ||
| }); |
Comment on lines
+5
to
+7
| CERTIFICATE_NOT_FOUND: (certificateLabel = 'default') => { | ||
| return `Certificate "${certificateLabel}" was not found.`; | ||
| }, |
Comment on lines
15
to
17
| (function () { | ||
| var questions = [ | ||
| let questions = [ | ||
| { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…validation