Fix interactive UI creating duplicate messages on button press#67
Open
zhou-zhichao wants to merge 1 commit intosix-ddc:mainfrom
Open
Fix interactive UI creating duplicate messages on button press#67zhou-zhichao wants to merge 1 commit intosix-ddc:mainfrom
zhou-zhichao wants to merge 1 commit intosix-ddc:mainfrom
Conversation
When editing an existing interactive message fails with "Message is not modified" (content unchanged after button press), the old code caught all exceptions and fell through to send a new message, causing duplicates. Changes: - Handle BadRequest "Message is not modified" specifically: keep existing message and return early instead of creating a duplicate - On other edit failures, send the replacement message first, then delete the old one only after the new one succeeds — prevents stranding users without controls if the replacement send also fails Fixes six-ddc#66
zhou-zhichao
force-pushed
the
fix/interactive-ui-duplicate-messages
branch
from
43448aa to
4106d55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BadRequest: Message is not modifiedspecifically — keep existing message instead of creating a duplicateProblem
Each button press (Up/Down/Enter/Space/Tab) on interactive UI inline keyboards could create a new message instead of editing the existing one. This happened because
handle_interactive_uicaught all exceptions fromedit_message_textand fell through tosend_messagewithout deleting the old message.The most common trigger: Telegram raises
BadRequest: Message is not modifiedwhen terminal content hasn't changed after a button press — the broadexcept Exceptiontreated this as a failure and sent a duplicate.Changes
Only
src/ccbot/handlers/interactive_ui.py:BadRequestfromtelegram.errorBadRequestwith "Message is not modified" → returnTrue(keep existing message)delete_messagethe old one before sending newTest plan
Fixes #66