Skip to content

ci: remove Harden Runner step#76

Merged
sjinks merged 1 commit into
masterfrom
remove-harden-runner
Aug 2, 2025
Merged

ci: remove Harden Runner step#76
sjinks merged 1 commit into
masterfrom
remove-harden-runner

Conversation

@sjinks

@sjinks sjinks commented Aug 2, 2025

Copy link
Copy Markdown
Owner

This pull request removes the usage of the step-security/harden-runner action across multiple GitHub workflow files. The harden-runner steps, which were responsible for enforcing egress policies and other security configurations, have been deleted. This simplifies the workflows but also removes the additional security measures provided by the action.

Summary by CodeRabbit

  • Chores
    • Removed the "Harden Runner" security step from all CI, lint, test, and CodeQL workflows. This change streamlines workflow execution without altering other steps or functionality.

@sjinks sjinks self-assigned this Aug 2, 2025
@sjinks sjinks requested a review from Copilot August 2, 2025 20:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes the step-security/harden-runner action from all GitHub workflow files, eliminating security hardening measures that previously enforced egress policies and network restrictions across CI/CD pipelines.

  • Removes Harden Runner security configurations from 6 workflow files
  • Eliminates egress policy enforcement (both audit and block modes)
  • Removes network endpoint restrictions and sudo access controls

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
.github/workflows/update-vcpkg-baseline.yml Removes Harden Runner with audit egress policy
.github/workflows/lint.yml Removes Harden Runner with block egress policy and specific endpoint allowlist
.github/workflows/ctest.yml Removes Harden Runner from both matrix setup and test execution jobs
.github/workflows/codeql.yml Removes Harden Runner with block egress policy and endpoint restrictions
.github/workflows/ci.yml Removes Harden Runner from multiple jobs with varying security configurations
.github/workflows/ci-vcpkg.yml Removes Harden Runner with audit egress policy

Comment thread .github/workflows/lint.yml
Comment thread .github/workflows/codeql.yml
Comment thread .github/workflows/ctest.yml
@sjinks sjinks merged commit ef28125 into master Aug 2, 2025
22 of 23 checks passed
@sjinks sjinks deleted the remove-harden-runner branch August 2, 2025 20:56
@coderabbitai

coderabbitai Bot commented Aug 2, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

All "Harden Runner" steps utilizing the step-security/harden-runner GitHub Action have been removed from multiple workflow files. These steps previously enforced runner hardening and network egress policies in CI, linting, testing, and update workflows. No other workflow logic, job steps, or configurations were changed.

Changes

Cohort / File(s) Change Summary
Removal of Harden Runner from CI Workflows
.github/workflows/ci.yml, .github/workflows/ci-vcpkg.yml, .github/workflows/codeql.yml, .github/workflows/ctest.yml, .github/workflows/lint.yml, .github/workflows/update-vcpkg-baseline.yml
All steps invoking the step-security/harden-runner action were removed from these workflows. This eliminates runner hardening and network egress restrictions. No other workflow steps or configurations were altered.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A bunny hopped through YAML fields,
Snipping harden steps from all the shields.
No more runner locks or network gates—
Just simple builds the workflow creates.
With lighter hops, the CI flows,
As carrot dreams in pipelines grow! 🥕

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3775d8 and c826e6a.

📒 Files selected for processing (6)
  • .github/workflows/ci-vcpkg.yml (0 hunks)
  • .github/workflows/ci.yml (0 hunks)
  • .github/workflows/codeql.yml (0 hunks)
  • .github/workflows/ctest.yml (0 hunks)
  • .github/workflows/lint.yml (0 hunks)
  • .github/workflows/update-vcpkg-baseline.yml (0 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-harden-runner

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants