Skip to content

Also check window title to support xwayland #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arroquw wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Also check window title to support xwayland #48

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
651e9e1
Support grabbing RS window through title
Arroquw Aug 1, 2024
c01c7b7
Fetch window title only for specific classname
Arroquw Jun 30, 2025
b074950
Always check title
Arroquw Jul 1, 2025
fc27d83
Fix bug where if checks for non 0 strcmp
Arroquw Jul 3, 2025
2798829
Remove geometry checking, not needed after bugfix
Arroquw Jul 3, 2025
e655cae
Remove debug prints
Arroquw Jul 3, 2025
ff49384
Use more robust title comparison
Arroquw Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions native/os_x11_linux.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,25 @@ bool IsRsWindow(const xcb_window_t window) {
memcpy(buffer, xcb_get_property_value(replyProp), len);
// first is instance name, then class name - both null terminated. we want class name.
const char* classname = buffer + strlen(buffer) + 1;
if (strcmp(classname, "RuneScape") == 0 || strcmp(classname, "steam_app_1343400") == 0 || strcmp(classname, "rs2client.exe") == 0) {
if (strcmp(classname, "RuneScape") == 0 || strcmp(classname, "steam_app_1343400") == 0 || strcmp(classname, "steam_proton") == 0 || strcmp(classname, "rs2client.exe") == 0) {
auto replyTransient = xcb_get_property_reply(connection, cookieTransient, NULL);
if (replyTransient && xcb_get_property_value_length(replyTransient) == 0) {
free(replyProp);
return true;
xcb_get_property_cookie_t cookie = xcb_get_property_unchecked(connection, 0, window, XCB_ATOM_WM_NAME, XCB_ATOM_STRING, 0, 100);
std::unique_ptr<xcb_get_property_reply_t, decltype(&free)> reply { xcb_get_property_reply(connection, cookie, NULL), &free };
if(reply) {
char* title = reinterpret_cast<char*>(xcb_get_property_value(reply.get()));
int length = xcb_get_property_value_length(reply.get());
auto str_title = std::string(title, length);
/* Covers both normal and compatibility mode (substring of RuneScape (compatibility mode) )*/
if (str_title.compare(0, sizeof("RuneScape") - 1, "RuneScape") == 0) {
if (replyTransient && xcb_get_property_value_length(replyTransient) == 0) {
free(replyProp);
return true;
} else {
std::cout << "NonTransient window found: " << str_title << std::endl;
}
}
}

}
}
}
Expand Down