refactor: enhance Java closure return value bridging#103
Merged
marcprux merged 2 commits intoskiptools:mainfrom Feb 18, 2026
Merged
refactor: enhance Java closure return value bridging#103marcprux merged 2 commits intoskiptools:mainfrom
marcprux merged 2 commits intoskiptools:mainfrom
Conversation
Improve return value bridging logic in `JavaBackedClosure` class to better support various Swift types. Add a method to retrieve a protocol bridge implementation type and gracefully handle unbridgeable types with a descriptive fatal error. This change ensures robust bridging of Java closures to their Swift representation, enhancing reliability and handling edge cases more effectively.
Member
|
Could you add a test case that demonstrates the protocol bridging? |
Introduce `kotlinClosure0ProtocolVar` that returns a `KotlinProtocol` type. The addition facilitates scenarios where closures return protocol types. Implement associated test cases in `testSupport_kotlinClosure0ProtocolVar` to ensure functionality correctness. This change enriches the flexibility of closures and supports protocol handling in closure definitions.
Contributor
Author
|
@marcprux done! |
Member
|
Great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve return value bridging logic in
JavaBackedClosureclass to better support various Swift types. Add a method to retrieve a protocol bridge implementation type and gracefully handle unbridgeable types with a descriptive fatal error. This change ensures robust bridging of Java closures to their Swift representation, enhancing reliability and handling edge cases more effectively.Skip Pull Request Checklist:
swift testAfter finding this crash:
With the help of Codex I demangled it and found that the crash was here:
SkipBridge.JavaBackedClosure.returnValue(for:) -> Awhere my Swift code looked like@escaping (URL, [String: String]) -> any WSConnection.At that point I cloned the repo and asked it to figure out a solution.