Configure navigation transitions#419
Open
dfabulich wants to merge 1 commit into
Open
Conversation
5 tasks
marcprux
added a commit
to dfabulich/skip-ui
that referenced
this pull request
May 14, 2026
Will be needed by skiptools#419
marcprux
added a commit
that referenced
this pull request
May 14, 2026
* Animate navigation bar visibility There are three kinds of changes here. 1. We have to plumb the `visibilityAnimation` through a preference so `Navigation.swift` can access it. 2. Adding in `AnimatedVisibility`. (This changes indentation on the whole file. Best viewed ignoring whitespace, e.g. with `git diff -w`) 3. Careful coordination of `contentSafeArea` with `topPadding`. These need to match each other on every frame of the animation, or the animation will judder. * Add back androidx.compose.animation.core.tween Will be needed by #419 --------- Co-authored-by: Marc Prud'hommeaux <marc@skip.tools>
marcprux
requested changes
May 14, 2026
Member
marcprux
left a comment
marcprux
left a comment
There was a problem hiding this comment.
I think there's a bug in here … the "back" navigation transition is now sliding the screen "forward".
dfabulich
force-pushed
the
configure-navigation-transitions
branch
from
63568bf to
49316b5
Compare
dfabulich
force-pushed
the
configure-navigation-transitions
branch
from
49316b5 to
3c11901
Compare
Contributor
Author
|
Sorry about that! That was last-minute cleanup gone wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip Pull Request Checklist:
swift testConfigure navigation transitions skip-fuse-ui#104
Cursor did the first draft; I heavily rewrote it (and wrote the README myself). I tested this by tweaking animations in the Showcase app, and by using it in my own app. I also tested it in the Fuse Showcase.