Replace Text link handling with LinkInteractionListener#436
Open
dfabulich wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
This PR will conflict with #434. Fun fact! I generated #434 and skiptools/skip-foundation#122 basically by accident, trying to fix #435. Cursor said "I know, why don't I just implement I looked at the resulting code and said… "Uh, this… this seems pretty good, but it's way overkill for what I needed to do. But… I can't just throw all this away, can I?!?" So I filed the other PRs in the hopes that I (or someone) actually fixes this at some point. |
2e9113d to
f6ad374
Compare
f6ad374 to
155ab80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #435
Skip Pull Request Checklist:
swift testNot required
Example of intercepted Markdown link text skipapp-showcase#105
Cursor did this; I tested it in the Showcase Lite app.