Skip to content

Replace Text link handling with LinkInteractionListener#436

Open
dfabulich wants to merge 1 commit into
skiptools:mainfrom
dfabulich:intercept-talkback-activated-link
Open

Replace Text link handling with LinkInteractionListener#436
dfabulich wants to merge 1 commit into
skiptools:mainfrom
dfabulich:intercept-talkback-activated-link

Conversation

@dfabulich
Copy link
Copy Markdown
Contributor

@dfabulich dfabulich commented May 18, 2026

Fixes #435

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device
  • REQUIRED: I have checked whether this change requires a corresponding update in the Skip Fuse UI repository (link related PR if applicable)
    Not required
  • OPTIONAL: I have added an example of any UI changes to the Showcase sample app
    Example of intercepted Markdown link text skipapp-showcase#105

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Cursor did this; I tested it in the Showcase Lite app.

@cla-bot cla-bot Bot added the cla-signed label May 18, 2026
@dfabulich
Copy link
Copy Markdown
Contributor Author

This PR will conflict with #434.

Fun fact! I generated #434 and skiptools/skip-foundation#122 basically by accident, trying to fix #435.

Cursor said "I know, why don't I just implement AttributedString for real?!" and then went ahead and just did it.

I looked at the resulting code and said… "Uh, this… this seems pretty good, but it's way overkill for what I needed to do. But… I can't just throw all this away, can I?!?" So I filed the other PRs in the hopes that I (or someone) actually fixes this at some point.

@dfabulich dfabulich force-pushed the intercept-talkback-activated-link branch from 2e9113d to f6ad374 Compare May 18, 2026 03:16
@dfabulich dfabulich force-pushed the intercept-talkback-activated-link branch from f6ad374 to 155ab80 Compare May 18, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't intercept Markdown links activated by Android Talkback

1 participant