Skip to content

Fix infinite recomposition in Text.foregroundStyle(LinearGradient()) #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dfabulich wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Fix infinite recomposition in Text.foregroundStyle(LinearGradient()) #438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Sources/SkipUI/SkipUI/Graphics/Gradient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,9 @@ public struct LinearGradient : ShapeStyle, Renderable {

@Composable override func asBrush(opacity: Double, animationContext: ComposeContext?) -> Brush? {
let stops = gradient.colorStops(opacity: opacity)
return LinearGradientShaderBrush(colorStops: stops, startPoint: startPoint, endPoint: endPoint)
return remember(gradient, startPoint, endPoint, opacity) {
Copy link
Copy Markdown
Member

@marcprux marcprux May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add remember(…) to the two places we create a RadialGradientShaderBrush?

LinearGradientShaderBrush(colorStops: stops, startPoint: startPoint, endPoint: endPoint)
}
}

private struct LinearGradientShaderBrush: ShaderBrush {
Expand Down