Adds bridged SwiftUI body Observation via withObservationTracking#251
Draft
woodymelling wants to merge 2 commits into
Draft
Adds bridged SwiftUI body Observation via withObservationTracking#251woodymelling wants to merge 2 commits into
woodymelling wants to merge 2 commits into
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the Skipstone change that inserts
withObservationTrackinginto all SwiftUI view body, and triggers recompisition in the didChange closure.This is a companion to this PR:
skiptools/skip-fuse-ui#112
and disabling the legacy Observation is required to test this properly.
skiptools/skip-android-bridge#25
Skip Pull Request Checklist:
swift test