Open
Conversation
Adding functionality to determine if datatype is trusted in the skops framework. Intended to help users determine what they are able to save safely so that a model can be loaded without the need to okay/verify untrusted datatypes.
Member
|
The issue here is that a type is trusted sometimes based on the context/node it's in. Some nodes also inject extra trusted types into the trusted set. So I'm not sure the implementation of such a feature would be feasible. Note that |
Author
|
Thanks for the explanation! If a node is injecting trusted types though that should be fine. The point of the function is to identify what types they can save to a skops file (e.g. numpy vs pandas) without have to use the |
Member
|
In that case, you can do something along the lines of: def is_trusted_by_default(obj):
return get_untrusted_types(dumps(obj)) == []That seems easy enough that users don't need a function for it, WDYT? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding functionality to determine if datatype is trusted in the skops framework.
Intended to help users determine what they are able to save safely so that a model can be loaded without the need to okay/verify untrusted datatypes.
Reference Issues/PRs
No references.
What does this implement/fix? Explain your changes.
This is meant to add simple functionality to determine if types are trusted within skops. The function is meant to help users identify what they can save within skops so that files can be loaded without the need to use the
trustedkeyword. This will hopefully help streamline the loading of.skopsfiles.Any other comments?
Also put a small change in
skops\docs\persistence.rstto help clarify that Supported libraries also meant Trusted libraries. When reading the documentation it was unclear exactly what was Trusted.This is my first pull request in a larger project. I've tried to make sure I've followed the rules as layed out in the Contributing guidelines. Apologies if I have not!