AB#536560: update dependencies - #117
Closed
Adam Cofer (acofer) wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s Go module dependencies (notably squirrel and DataDog/OpenTelemetry-related transitive deps) and adjusts SQL-related tests to match updated query rendering behavior.
Changes:
- Bumps Go module dependencies in
go.modand refreshesgo.sum. - Updates SQL expectation tests to accept
(1=1)output for empty/no-op predicates. - Tweaks developer tooling in
Makefile(test targets and adds anupdatetarget).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
go.mod |
Updates direct/indirect module versions and changes the Go version directive. |
go.sum |
Regenerated checksums reflecting updated module versions. |
tags/tags_test.go |
Updates null-filter tests to expect (1=1) for empty/invalid fields. |
filter_test.go |
Updates expected SQL to include an (1=1) no-op clause. |
Makefile |
Adjusts test targets and adds an update helper target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
233
to
235
| assert.NoError(t, err) | ||
| // Empty Eq{} produces empty SQL | ||
| assert.Empty(t, sql) | ||
| assert.Equal(t, sql, "(1=1)") | ||
| assert.Empty(t, args) |
Comment on lines
248
to
250
| assert.NoError(t, err) | ||
| assert.Empty(t, sql) | ||
| assert.Equal(t, sql, "(1=1)") | ||
| assert.Empty(t, args) |
Comment on lines
10
to
+14
| test: | ||
| # @make service | ||
| @go test -cover ./... | ||
|
|
||
| @go test ./... | ||
|
|
||
| testv: | ||
| @go test -v -cover ./... | ||
| @go test -v ./... |
Contributor
Author
|
Superseded by #118 |
Adam Cofer (acofer)
deleted the
AB#536560-veracode_remediation_dependency_updates
branch
July 14, 2026 15:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link
https://dev.azure.com/nintex/Nintex/_workitems/edit/536560
High-Level Description
Changelog: