give non-kube users info when system uninstall fails#2358
Open
pwright wants to merge 3 commits intoskupperproject:mainfrom
Open
give non-kube users info when system uninstall fails#2358pwright wants to merge 3 commits intoskupperproject:mainfrom
pwright wants to merge 3 commits intoskupperproject:mainfrom
Conversation
c-kruse
reviewed
Jan 22, 2026
c-kruse
requested changes
Jan 22, 2026
Contributor
c-kruse
left a comment
c-kruse
left a comment
There was a problem hiding this comment.
Looks good aside from the duplicate output
Co-authored-by: Christian Kruse <ck@c-kruse.com>
nluaces
reviewed
Jan 30, 2026
| return err | ||
| } | ||
|
|
||
| if len(entries) == 0 { |
Member
There was a problem hiding this comment.
This message is not printed when there are no namespaces to remove:
nluaces:skupper$ skupper system install
Pulled system-controller image: quay.io/skupper/system-controller:v2-dev
Platform podman is now configured for Skupper
nluaces:skupper$ skupper system uninstall --force
System-controller has been removed
Platform podman infrastructure for Skupper is now uninstalled
Because in that directory there is an entry called controller.lock, I think it is better to check that there are no directories instead of entries, or just to remove that message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2354