added additional network observer /metrics endpoint#2374
Merged
JPadovano1483 merged 2 commits intoskupperproject:mainfrom Feb 12, 2026
Merged
added additional network observer /metrics endpoint#2374JPadovano1483 merged 2 commits intoskupperproject:mainfrom
JPadovano1483 merged 2 commits intoskupperproject:mainfrom
Conversation
JPadovano1483
requested review from
c-kruse,
fgiorgetti and
nluaces
as code owners
c-kruse
reviewed
Feb 9, 2026
Contributor
c-kruse
left a comment
c-kruse
left a comment
There was a problem hiding this comment.
Just a few small suggestions, otherwise this is great!
cmd/network-observer/main.go
Outdated
|
|
||
| flags.StringVar(&cfg.VanflowLoggingProfile, "vanflow-logging-profile", "silent", "Controls low level vanflow record logging. Options are silent, minimal, moderate and all") | ||
|
|
||
| flags.StringVar(&cfg.MetricsListenAddress, "listen-metrics", ":9000", "The address that the Metrics Server will listen on.") |
Contributor
There was a problem hiding this comment.
Suggest defaulting this to "" so that it is off by default.
| name: {{ include "network-observer.fullname" . }}-metrics | ||
| labels: | ||
| {{ include "network-observer.labels" . | nindent 4 }} | ||
| app: metrics |
Contributor
There was a problem hiding this comment.
app does not seem quite right to me. Maybe app.kubernetes.io/component instead?
c-kruse
approved these changes
Feb 11, 2026
Contributor
c-kruse
left a comment
c-kruse
left a comment
There was a problem hiding this comment.
Very nice!
Deployed to openshift, added a ServiceMonitor, and it worked great.
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
name: network-observer-metrics
spec:
endpoints:
- interval: 30s
port: metrics
selector:
matchLabels:
app.kubernetes.io/component: metrics
app.kubernetes.io/part-of: skupper-network-observer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a metrics endpoint to the network-observer container to allow external metrics collection
Fixes #2194