Prefix tcpListener/tcpConnector names to avoid same-site collision with exposePodsByName. Added test in controller_test.go.#2381
Open
AryanP123 wants to merge 1 commit intoskupperproject:mainfrom
Conversation
…th exposePodsByName. Added test in controller_test.go Fixes skupperproject#2058
AryanP123
requested review from
c-kruse,
fgiorgetti and
nluaces
as code owners
c-kruse
reviewed
Feb 13, 2026
Contributor
c-kruse
left a comment
c-kruse
left a comment
There was a problem hiding this comment.
Nice! This was a lot cleaner than I had initially thought.
I know it was me who suggested a resource-type.resource-name scheme, but I'd like to walk that back. We should definitely pick something that cannot be a in a k8s resource name. I'd lean towards /.
Also, the catch here that we should call out is that this does end up bubbling back to the user in site.status.network.services.listeners. Maybe not a deal breaker, but something we should be careful to consider and maybe document.
Thoughts on that @fgiorgetti?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2058