Skip to content

security: add zero-address validation and fix pragma consistency - #43

Open
canychan wants to merge 1 commit into
sky-ecosystem:masterfrom
canychan:security-fixes-zero-address
Open

security: add zero-address validation and fix pragma consistency#43
canychan wants to merge 1 commit into
sky-ecosystem:masterfrom
canychan:security-fixes-zero-address

Conversation

@canychan

Copy link
Copy Markdown

Security Improvements

Changes

  1. Zero-address validation in constructor (src/flash.sol)

    • Added require(daiJoin_ != address(0)) to prevent deployment with invalid address
    • Without this check, deploying with address(0) renders the contract permanently unusable
  2. Fixed floating pragma (src/base/FlashLoanReceiverBase.sol)

    • Changed to pragma solidity 0.6.12 to match main contract

Impact

  • Severity: Low (defensive coding)
  • No functional or breaking changes

@DaiFoundation-DevOps

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants