This repository was archived by the owner on Oct 8, 2024. It is now read-only.
Upgrade to solc 0.6.12 and several improvements#32
Open
gbalabasquer wants to merge 59 commits intomasterfrom
Open
Upgrade to solc 0.6.12 and several improvements#32gbalabasquer wants to merge 59 commits intomasterfrom
gbalabasquer wants to merge 59 commits intomasterfrom
Conversation
* Adapt for solc 0.6 * Fix travis
* Fix minor _getDrawDart bug * Fix comment
* make vat and manager immutable * Minor changes * Remove deprecated functions * Make public the immutable variables
talbaneth
previously approved these changes
Sep 29, 2022
talbaneth
left a comment
talbaneth
left a comment
There was a problem hiding this comment.
LGTM.
We should probably still discuss the dust issue.
Contributor
Author
|
@talbaneth whenever you can give a final approval including the latest changes would be nice. |
gbalabasquer
dismissed stale reviews from talbaneth and iamchrissmith
via
b268061
iamchrissmith
previously approved these changes
Nov 22, 2022
gbalabasquer
dismissed stale reviews from talbaneth and iamchrissmith
via
40bb449
Contributor
Author
|
@iamchrissmith @talbaneth will require a check in the last commit from you, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.