This repository was archived by the owner on Apr 18, 2023. It is now read-only.
Add declaration file to support TypeScript better#23
Merged
levity merged 3 commits intosky-ecosystem:masterfrom Nov 19, 2020
chiro-hiro:master
Merged
Add declaration file to support TypeScript better#23levity merged 3 commits intosky-ecosystem:masterfrom chiro-hiro:master
levity merged 3 commits intosky-ecosystem:masterfrom
chiro-hiro:master
Conversation
Contributor
|
Thank you! This looks good. The only question I have is, why do all the types start with |
Contributor
Author
|
I've found it's convenience then I put it here. |
Contributor
Author
|
@levity Hi, Are we have any update here? |
Contributor
|
Hi @chiro-hiro, thanks for the reminder, I'll merge this now |
Contributor
|
Published 0.12.0 to npm with this change |
Contributor
Author
|
@levity If there are anything need to be changed, just let me know. I will keep one eye on it and update interfaces. Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a little bit hard to use this package in TypeScript. I hope, this pull request could make this package is more friendly with TypeScript developers.