Skip to content
This repository was archived by the owner on Apr 18, 2023. It is now read-only.

Add declaration file to support TypeScript better#23

Merged
levity merged 3 commits intosky-ecosystem:masterfrom
chiro-hiro:master
Nov 19, 2020
Merged

Add declaration file to support TypeScript better#23
levity merged 3 commits intosky-ecosystem:masterfrom
chiro-hiro:master

Conversation

@chiro-hiro
Copy link
Contributor

@chiro-hiro chiro-hiro commented Oct 13, 2020

It's a little bit hard to use this package in TypeScript. I hope, this pull request could make this package is more friendly with TypeScript developers.

@levity
Copy link
Contributor

levity commented Oct 16, 2020

Thank you! This looks good. The only question I have is, why do all the types start with I? Is this a TypeScript convention I'm not aware of?

@chiro-hiro
Copy link
Contributor Author

chiro-hiro commented Oct 17, 2020

I is stand for interface, some other projects are also use this kind of naming. For example, you type I then the IDE could suggest all interfaces.

I've found it's convenience then I put it here.

@chiro-hiro
Copy link
Contributor Author

@levity Hi, Are we have any update here?

@levity
Copy link
Contributor

levity commented Nov 19, 2020

Hi @chiro-hiro, thanks for the reminder, I'll merge this now

@levity levity closed this Nov 19, 2020
@levity levity reopened this Nov 19, 2020
@levity levity merged commit fecc651 into sky-ecosystem:master Nov 19, 2020
@levity
Copy link
Contributor

levity commented Nov 19, 2020

Published 0.12.0 to npm with this change

@chiro-hiro
Copy link
Contributor Author

@levity If there are anything need to be changed, just let me know. I will keep one eye on it and update interfaces.

Thanks,

@islishude
Copy link

@levity Hi,the type files are ignored on npm,I just filed a pr to fix this #33

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants