Open
Conversation
Comment on lines
191
to
+194
| * Cast spell on a newly created Tenderly Testnet | ||
| * [ ] `export TENDERLY_USER='<ORG_SLUG>'` (e.g.: dewiz-xyz) | ||
| * [ ] `export TENDERLY_PROJECT='makerdao'` | ||
| * [ ] `export TENDERLY_ACCESS_KEY='<ACCESS_KEY>'` (from the **account level**, not from the organization level) |
Contributor
There was a problem hiding this comment.
I don't think checklist is a good place to store env variables and setup instructions:
- Setup only needs to happen once while every checklist item suppose to be followed every single time
- Code of the tenderly script lays in a different repository so it's harder to maintain two places in sync
Instead, you can link a readme section that already explains that:
Suggested change
| * Cast spell on a newly created Tenderly Testnet | |
| * [ ] `export TENDERLY_USER='<ORG_SLUG>'` (e.g.: dewiz-xyz) | |
| * [ ] `export TENDERLY_PROJECT='makerdao'` | |
| * [ ] `export TENDERLY_ACCESS_KEY='<ACCESS_KEY>'` (from the **account level**, not from the organization level) | |
| * Cast spell on a newly created Tenderly Testnet (see [setup instructions](https://github.com/makerdao/spells-mainnet?tab=readme-ov-file#cast-to-tenderly)) |
Alternatively, you can submit a PR into makerdao/spells-mainnet to move this setup instructions into a more visible place (eg inside relevant folder)
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the latest spell I spent quite a bit of time trying to use my Tenderly user ID in the env var
TENDERLY_USER, when I should be using my team's ID instead. This PR updates the checklist to detail what goes in each of the ENV vars in a way similar to the deployment script section.