Merged
Conversation
0xBasset
approved these changes
Apr 2, 2026
amusingaxl
reviewed
Apr 2, 2026
SidestreamBurningBanana
approved these changes
Apr 15, 2026
Contributor
SidestreamBurningBanana
left a comment
There was a problem hiding this comment.
Approving after running both scripts:
$ make safeharbor-generate
cd scripts/safeharbor && npm --silent ci && npm run --silent generate
Fetching chains details CSV...
Fetching CSV from https://docs.google.com/spreadsheets/d/1e_KOYOeBGaA5EG3Xqco6lOP_a0zV4Vrm3w5-dqFk00U/export?format=csv&gid=1620276618
Downloading contracts in scope CSV...
Fetching CSV from https://docs.google.com/spreadsheets/d/1e_KOYOeBGaA5EG3Xqco6lOP_a0zV4Vrm3w5-dqFk00U/export?format=csv&gid=1121763694
Fetching on-chain state...
Generating updates...
No updates to generate
$ make safeharbor-inspect
cd scripts/safeharbor && npm --silent ci && npm run --silent inspect
Fetching chains details CSV...
Fetching CSV from https://docs.google.com/spreadsheets/d/1e_KOYOeBGaA5EG3Xqco6lOP_a0zV4Vrm3w5-dqFk00U/export?format=csv&gid=1620276618
Downloading contracts in scope CSV...
Fetching CSV from https://docs.google.com/spreadsheets/d/1e_KOYOeBGaA5EG3Xqco6lOP_a0zV4Vrm3w5-dqFk00U/export?format=csv&gid=1121763694
Fetching on-chain state...
Generating updates...
No updates to generate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While working on the spell
2026-03-26, we identified three minor points regarding Safe Harbor:// ---------- Bug Bounty Updates ----------, which resulted in two headers inside the spell and made it slightly confusing to read, so to address this, we have removed the harcoded header generated by the script--silentflag to Safe Harbor commands to reduce noise and removed; cd -since make runs commands in subshells and no need to return to the previous directory manuallyContribution Checklist
(PE-<TICKET_NUMBER>)Checklist
officeHoursmodifier override30 daysunless otherwise specified)ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploymainnetcontract on etherscanmake archive-spellormake date="YYYY-MM-DD" archive-spellto make an archive directory and copyDssSpell.sol,DssSpell.t.sol,DssSpell.t.base.sol, andDssSpellCollateralOnboarding.solsquash and mergethis PR