Skip to content

Fix: SafeHarbor script output#538

Merged
amusingaxl merged 6 commits intomasterfrom
fix/safeharbor-script-output
Apr 15, 2026
Merged

Fix: SafeHarbor script output#538
amusingaxl merged 6 commits intomasterfrom
fix/safeharbor-script-output

Conversation

@SidestreamFrostyFig
Copy link
Copy Markdown
Contributor

Description

While working on the spell 2026-03-26, we identified three minor points regarding Safe Harbor:

  • The script outputs additional header // ---------- Bug Bounty Updates ----------, which resulted in two headers inside the spell and made it slightly confusing to read, so to address this, we have removed the harcoded header generated by the script
  • The README of the Safe Harbor script contained a broken link. We have updated it to point to the audited commit referenced in the forum post, which contains the registry contracts
  • The script output was somewhat noisy, so we added --silent flag to Safe Harbor commands to reduce noise and removed ; cd - since make runs commands in subshells and no need to return to the previous directory manually

Contribution Checklist

  • PR title starts with (PE-<TICKET_NUMBER>)
  • Code approved
  • Tests approved
  • CI Tests pass

Checklist

  • Every contract variable/method declared as public/external private/internal
  • Consider if this PR needs the officeHours modifier override
  • Verify expiration (30 days unless otherwise specified)
  • Verify hash in the description matches here
  • Validate all addresses used are in changelog or known
  • Notify any external teams affected by the spell so they have the opportunity to review
  • Deploy spell ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
  • Verify mainnet contract on etherscan
  • Change test to use mainnet spell address and deploy timestamp
  • Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
  • squash and merge this PR

@SidestreamFrostyFig SidestreamFrostyFig changed the title Fix: safeharbor script output Fix: SafeHarbor script output Apr 2, 2026
Comment thread Makefile
Copy link
Copy Markdown
Contributor

@SidestreamBurningBanana SidestreamBurningBanana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after running both scripts:

$ make safeharbor-generate
cd scripts/safeharbor && npm --silent ci && npm run --silent generate
Fetching chains details CSV...
Fetching CSV from https://docs.google.com/spreadsheets/d/1e_KOYOeBGaA5EG3Xqco6lOP_a0zV4Vrm3w5-dqFk00U/export?format=csv&gid=1620276618
Downloading contracts in scope CSV...
Fetching CSV from https://docs.google.com/spreadsheets/d/1e_KOYOeBGaA5EG3Xqco6lOP_a0zV4Vrm3w5-dqFk00U/export?format=csv&gid=1121763694
Fetching on-chain state...
Generating updates...
No updates to generate

$ make safeharbor-inspect
cd scripts/safeharbor && npm --silent ci && npm run --silent inspect
Fetching chains details CSV...
Fetching CSV from https://docs.google.com/spreadsheets/d/1e_KOYOeBGaA5EG3Xqco6lOP_a0zV4Vrm3w5-dqFk00U/export?format=csv&gid=1620276618
Downloading contracts in scope CSV...
Fetching CSV from https://docs.google.com/spreadsheets/d/1e_KOYOeBGaA5EG3Xqco6lOP_a0zV4Vrm3w5-dqFk00U/export?format=csv&gid=1121763694
Fetching on-chain state...
Generating updates...
No updates to generate

@amusingaxl amusingaxl merged commit 1d38b26 into master Apr 15, 2026
3 checks passed
@amusingaxl amusingaxl deleted the fix/safeharbor-script-output branch April 15, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants