fix(update): honest winget-upgrade narration + unblock the musl release build#519
Merged
Merged
Conversation
… leg
`cargo zigbuild <args>` forwards to the `zigbuild` subcommand, which rejects
`--version` ("unexpected argument"), so the musl matrix leg failed before the
real build ran — and create-github-release (needs the whole build matrix) was
skipped, publishing no Linux asset. Remove the smoke line; the real
`cargo zigbuild --release` step is the proof and @0.22.3 is already pinned.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…update Three fixes from live-Windows testing of the winget upgrade flow, so manual + winget install/uninstall/upgrade narrate what actually happened: - Stop claiming the Access Broker was "NOT updated" when it lives in a WinGet-delegated root: there the caller's `winget upgrade` swaps uffs-broker.exe and cycles the service, so it DOES reach the new version. The note contradicted the very next "Restarting the broker service" line. Gate on broker_in_winget_root() (read before drop_broker). - Don't count the broker as a required core binary in has_missing_core. It is a once-installed Windows service, legitimately absent from a hand-placed CLI root; requiring it marked a fully-current install "incomplete" and fired a pointless update + UAC on every `--update` when the broker sat in the winget root. - Keep WinGet-delegated components out of the alarming "failed to restart" warning. The caller stops them up front and its `resume` relaunches them on the new binary, so a non-elevated apply that can't restart them here left nothing broken — report it as a note, not a fault. Tests: root_missing_core broker-exclusion, broker_in_winget_root, winget_delegated_components (forward-slash paths for cross-platform split). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folds four fixes from live-Windows testing of the winget upgrade flow so manual + winget install / uninstall / upgrade all narrate what actually happened. Precursor to shipping 0.6.22 (0.6.21's release build failed on the musl leg below and published nothing — latest stayed 0.6.20).
ci(release)— unblock the static-musl Linux buildcargo zigbuild <args>forwards to thezigbuildsubcommand, which rejects--version(unexpected argument). The smoke line failed the musl matrix leg before the real build ran, socreate-github-release(needs the whole build matrix) was skipped — no Linux asset. Removed the line; the realcargo zigbuild --releasestep is the proof and@0.22.3is pinned.fix(update)— three narration/behaviour fixeswinget upgradeswapsuffs-broker.exeand cycles the service, so it does reach the new version. The note contradicted the very nextRestarting the broker serviceline. Gated onbroker_in_winget_root().has_missing_corecounteduffs-brokeras required in every unmanaged root, but it is a once-installed Windows service, legitimately absent from a hand-placed CLI root — so a fully-current install looked "incomplete". Broker excluded from the required set.resumerelaunches them on the new binary, so a non-elevated apply that can't restart them here left nothing broken.Tests
root_missing_corebroker-exclusion,broker_in_winget_root,winget_delegated_components(forward-slash paths so the component split runs cross-platform). Clippy clean on both crates.