fix(update): calm narration when WinGet lacks the new version yet (0x8a15002b)#524
Merged
Merged
Conversation
…8a15002b)
Right after a release the WinGet manifest publishes a bit later than the GitHub
release, so `uffs --update`'s winget step hit winget's "no applicable upgrade"
exit code (0x8a15002b) and printed a scary "winget upgrade did not complete".
That code just means "nothing newer available yet" — not a failure.
run_winget_upgrade now returns Updated / NotAvailableYet: the NotAvailableYet
case is narrated as a plain note ("WinGet doesn't have vX.Y.Z yet — the winget
copy catches up on the next `uffs --update`"), and any genuine winget failure
now also names the likely publish-lag cause instead of only a raw code.
Windows-only (windows_impl); verified with `cargo xwin check`/`clippy` for
x86_64-pc-windows-msvc. Unit test covers the exit-code classifier.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last loose end from the dual-install
uffs --updatesession.Right after a release the WinGet manifest publishes a bit later than the GitHub release, so
uffs --update's winget step hits winget's "no applicable upgrade" exit code0x8a15002band printed a scarywinget upgrade did not complete. That code just means "nothing newer available yet" — not a failure.run_winget_upgradenow returnsUpdated/NotAvailableYet. TheNotAvailableYetcase is narrated as a plain note ("WinGet doesn't have vX.Y.Z yet — the winget copy catches up on the nextuffs --update").Verified
Windows-only (
windows_impl) — validated locally withcargo xwin check+clippyforx86_64-pc-windows-msvc(0 warnings). Unit test covers the exit-code classifier.[Unreleased]changelog entry added (per-PR habit).