fix for asdf:monolithic-compile-bundle-op in abcl#9
Open
vibs29 wants to merge 1 commit intoskypher:masterfrom
Open
fix for asdf:monolithic-compile-bundle-op in abcl#9vibs29 wants to merge 1 commit intoskypher:masterfrom
vibs29 wants to merge 1 commit intoskypher:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ABCL produces a warning when loading this system:
; Caught SIMPLE-WARNING: ; compiling #<CL-STORE.SYSTEM:NON-REQUIRED-FILE "cl-store" "custom"> completed without its input file #P"/Volumes/vibhu/Downloads/cl-store-master/abcl/custom.lisp" or its output file #P"/Volumes/vibhu/.cache/common-lisp/abcl-1.4.0-fasl42-macosx-x64/Volumes/vibhu/Downloads/cl-store-master/abcl/custom.abcl"and also an error if you do:
(asdf:operate 'asdf:monolithic-compile-bundle-op "cl-store")#<THREAD "interpreter" {38CDE13}>: Debugger invoked on condition of type FILE-ERRORNo file found: org.armedbear.lisp.Pathname@8a53e04So something about the non-required-file machinery in cl-store.asd is not working for abcl. Perhaps we need to define another method on the class, non-required-file. I can't tell.
This commit works around the problem.