This repository was archived by the owner on Feb 18, 2026. It is now read-only.
Refactor: Mark internal methods as private#19
Open
ThisIsMissEm wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
I'm unsure if it actually makes sense to expose the methods We could have a // Assumes Label has `sig: Bytes; src: Did; uri: Did | CanonicalResourceUri;`
type CreateLabelData = MakeOptional<Omit<Label, "$type" | "ver" | "sig"> & { src: string, uri: string }, "cts" | "src">
type SavedLabel = Label & { id: number; }Which would get us down to just three exported types for the public API for labels, which would be more understandable from a public API documentation perspective. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up the documentation a bit, here's the existing:

And the new:
Whilst one could argue this is a breaking change, by making
appprivate, it didn't currently work correctly for registering additional routes due to the issues described in #8