Chore/3399 add vitest visual testing support to components repo#3410
Open
a11ymiko wants to merge 14 commits into
Open
Chore/3399 add vitest visual testing support to components repo#3410a11ymiko wants to merge 14 commits into
a11ymiko wants to merge 14 commits into
Conversation
|
Contributor
🕸 Preview deploys |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Vitest-based visual regression testing support to the components monorepo by introducing the Chromatic Vitest integration and a first example visual spec, wired into the repo’s existing multi-project Vitest setup and Wireit scripts.
Changes:
- Adds a new
visualVitest project that runsvisual/*.visual.spec.tswith@chromatic-com/vitest’schromaticPlugin(). - Introduces Wireit scripts (
test:visual,test:visual:ci) and a sample visual spec forsl-menu-button. - Updates
yarn.lockto include the new Chromatic Vitest dependency tree.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| yarn.lock | Adds lockfile entries for @chromatic-com/vitest and transitive deps. |
| vitest.config.ts | Adds a visual Vitest project and loads chromaticPlugin(). |
| visual/menu-button.visual.spec.ts | New visual regression spec exercising the menu-button story + interactions. |
| package.json | Adds Wireit tasks for visual tests and installs @chromatic-com/vitest. |
a11ymiko
requested review from
Diaan,
anna-lach,
jpzwarte and
michal-sanoma
as code owners
Comment on lines
+74
to
+78
| - name: Upload Vitest archives to Chromatic | ||
| run: yarn exec chromatic --vitest --project-token=${{ secrets.CHROMATIC_TOKEN_VISUAL }} | ||
| env: | ||
| CHROMATIC_SHA: ${{ github.sha }} | ||
| CHROMATIC_BRANCH: ${{ github.ref_name }} |
Comment on lines
+384
to
+387
| "files": [ | ||
| ".storybook/vitest.setup.ts", | ||
| "visual/**/*.visual.spec.ts" | ||
| ] |
Comment on lines
+396
to
+399
| "files": [ | ||
| ".storybook/vitest.setup.ts", | ||
| "visual/**/*.visual.spec.ts" | ||
| ] |
Comment on lines
+54
to
+69
| const waitForPopoverState = async (menu: MenuElement, expectedOpen: boolean) => { | ||
| let attempts = 0; | ||
|
|
||
| while (attempts < 50) { | ||
| const isOpen = menu.matches(':popover-open'); | ||
| if (isOpen === expectedOpen) { | ||
| return; | ||
| } | ||
|
|
||
| await new Promise(resolve => requestAnimationFrame(resolve)); | ||
| attempts++; | ||
| } | ||
|
|
||
| throw new Error( | ||
| `Timed out waiting for menu popover state "${expectedOpen ? 'open' : 'closed'}".` | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.