Skip to content

chore: increase the robustness of the uninstall script #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilliamBergamin merged 2 commits into from
Jun 19, 2025
+8 −2
Merged

chore: increase the robustness of the uninstall script #1704

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2432489
chore: increase the robustness of the uninstall script
WilliamBergamin Jun 18, 2025
02e27d1
Update uninstall_all.sh
WilliamBergamin Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions scripts/uninstall_all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
#!/bin/bash

pip uninstall -y slack-sdk && \
pip freeze | grep -v "^-e" | sed 's/@.*//' | sed 's/\=\=.*//' | xargs pip uninstall -y
# remove slack-sdk without a version specifier so that local builds are cleaned up
pip uninstall -y slack-sdk
# collect all installed packages
PACKAGES=$(pip freeze | grep -v "^-e" | sed 's/@.*//' | sed 's/\=\=.*//')

@zimeg zimeg Jun 18, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PACKAGES=$(pip freeze | grep -v "^-e" | sed 's/@.*//' | sed 's/\=\=.*//')
PACKAGES=$(pip freeze --local | grep -v "^-e" | sed 's/@.*//' | sed 's/\=\=.*//')

I'm often working in isolated virtual environments, but this option might be neat to consider while this is being changed:

  -l, --local                 If in a virtualenv that has global access, do not output globally-installed packages.

@WilliamBergamin WilliamBergamin Jun 19, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should be requiring maintainers to work in isolated environments 🤔 If a maintainer is intentionally using a virtualenv that has global access then they should know what they are doing

I see this script as being simple and definitive ⚠️ it should uninstall all dependencies, I wouldn't want a maintainer to start digging into why in some situation dependencies are persisted in their environment

If someone reports encountering this issue regularly then we can add the --local flag in

# uninstall packages without exiting on a failure
for package in $PACKAGES; do
pip uninstall -y $package
done