test: validate cross-skill references in skill files#59
Merged
Conversation
Add unit tests that enforce the cross-skill reference conventions: - references use the `plugin:skill` form and target a real skill - no markdown anchor links (`[text](#anchor)`) - no bare `SKILL.md` file paths Derive the plugin namespace from the plugin manifest so the tests stay in sync with the manifest, and document the conventions in AGENTS.md. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
mwbrooks
approved these changes
Jun 26, 2026
mwbrooks
left a comment
mwbrooks
left a comment
Member
There was a problem hiding this comment.
✅ Thanks @WilliamBergamin! This is a very nice lint test to have!
🧪 I've manually tested by introducing invalid skill references and using markdown link references. Both work well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests that enforce the cross-skill reference conventions documented in
AGENTS.md, so skill authors get fast CI feedback when a reference drifts.The new
tests/unit/test_cross_skill_references.pychecks every skill body for:`plugin:skill`reference points at a skill that actually exists.[text](#anchor)links, which don't resolve in installed skills.SKILL.mdpaths; use the backtickedplugin:skillform instead.Testing
make test-unit: all 12 unit tests pass (3 new).🤖 Generated with Claude Code