Update enum generation key formatting#83
Merged
yucombinator merged 2 commits intoslackhq:masterfrom Mar 3, 2025
Merged
Conversation
|
Thanks for the contribution! Before we can merge this, we need @ZachJBurns to sign the Salesforce Inc. Contributor License Agreement. |
chaseajen
reviewed
Feb 28, 2025
| $members = \HH\Lib\Vec\map( | ||
| $enum, | ||
| $member ==> $factory->codegenEnumMember(Str\uppercase($member)) | ||
| $member ==> $factory->codegenEnumMember(Str\uppercase(Str\replace_every($member, dict[':' => '_', '.' => '_']))) |
There was a problem hiding this comment.
it's a bit stylistic, but what do you think about:
$member ==> Str\replace_every($member, dict[':' => '_', '.' => '_'])
|> Str\uppercase($$)
|> $factory->codegenEnumMember($$)->setValue($$, HackBuilderValues::export()),just to remove some of the nesting and get a bit more clarity?
Contributor
Author
There was a problem hiding this comment.
Looks a lot better now! And got the CLA test to run again 😄
chaseajen
approved these changes
Feb 28, 2025
yucombinator
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates enum key generation to convert
:and.to_.