Skip to content

Feat/user gid query#24

Merged
amithmslac merged 3 commits into
mainfrom
feat/user-gid-query
Jun 12, 2026
Merged

Feat/user gid query#24
amithmslac merged 3 commits into
mainfrom
feat/user-gid-query

Conversation

@amithmslac

Copy link
Copy Markdown
Contributor

Pull users uid, primary gid and secondary gids through user-lookup

@amithmslac
amithmslac requested review from 2Ryan09 and yee379 June 12, 2026 20:59
Comment thread models.py
return sorted(list(set([x["facility"] for x in info.context.db.collection("repos").find({"name": "default", "users": self.username}, {"_id": 0, "facility": 1})])))

@strawberry.field
def gids(self, info) -> List[int]:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

biggest concern remains this field being 90% duplicate of accessGroupObjs, but not a blocker

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of data type (representation of what the data is), yes. The data source is different, we're going through user-lookup which interfaces both sdf ldap and slac it to provide this data. Agree with you that we will need to revisit this as part of the NIS migration.

@amithmslac
amithmslac merged commit 7769d06 into main Jun 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants