Preserve existing users and leaders in NewRepo requests#20
Merged
Conversation
This reverts commit f6281ed.
There was a problem hiding this comment.
Pull request overview
This PR updates the RepoRegistration.do_new_repo() workflow to make NewRepo requests idempotent by preserving existing repository users and leaders when re-running repo creation, and extends the test suite to cover the new behavior.
Changes:
- Added a pre-upsert GraphQL query in
do_new_repo()to preserve existingusers/leadersand passrepo_usersinto the Ansibleadd_repo.yamlplaybook. - Updated existing GID-related tests to account for the new initial GraphQL call and playbook parameter.
- Added new tests covering NewRepo idempotency for both fresh and re-run scenarios.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| modules/coactd.py | Adds repo lookup logic to preserve existing users/leaders and passes repo_users into the playbook and upsert payload. |
| tests/test_repo_registration_gid.py | Updates existing tests for the extra GraphQL call and adds new idempotency-focused test coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yee379
approved these changes
Jun 19, 2026
pjpascual
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.