Prepare Flags for Overhaul#38
Open
matttproud wants to merge 2 commits into
Open
Conversation
The acceptable value representation code had been dead for ages. The validator behavior never belonged in the formatter, and the extraction of it yields many nice future simplifications.
In forthcoming iterations, this aids in simplifying materialized arguments by defining specific formatters inside of the JvmFlag enum. This also makes the "Tuny" prototyping easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent changes: Emit formatted flags as lists, and extract validation to its own domain type.
To better manage the overhaul of how the garbage collection strategy selection and such is handled, we need to simplify the flag representation even further. Without doing this, we make a bigger mess for ourselves. The simplifications allow us to start dropping the one-off treatment of argument formation in
CommandLineand rely onJvmFlagfor a naive search space. This is to say, if we want to support semantically incorrect search space generation, then we need to enable to code to do so easily.@etheon, this will need some careful consideration.