optional ExpressionPreprocessor for COO values before rank/bin#57
Merged
Conversation
Add ExpressionPreprocessor (normalize_total, log1p) and apply_expression_preprocessor, which no-ops on None or empty config. Wire expression_preprocessor through SLAFDataLoader, SLAFIterableDataset, PrefetchBatchProcessor, and DistributedSLAFDataLoader into window kwargs. ScGPTWindow skips a second log1p when preprocessor.log1p is true. Export from slaf.ml; add aggregator tests. Made-with: Cursor
pavanramkumar
added a commit
to alam-shahul/slaf
that referenced
this pull request
May 28, 2026
Pass SLAFArray to tokenizers again and apply normalize/log1p upstream via ExpressionPreprocessor in window aggregators. Restore dataloader and worker APIs from post-slaf-project#57; keep epoch field on prefetch batches for reporting. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ExpressionPreprocessor (normalize_total, log1p) and apply_expression_preprocessor, which no-ops on None or empty config. Wire expression_preprocessor through SLAFDataLoader, SLAFIterableDataset, PrefetchBatchProcessor, and DistributedSLAFDataLoader into window kwargs.
ScGPTWindow skips a second log1p when preprocessor.log1p is true. Export from slaf.ml; add aggregator tests.