fix: define datetime resolution attribute#185
Merged
Conversation
Define datetime.min, datetime.max, and datetime.resolution instead of inheriting them from date. This aligns the API with the stdlib, where datetime exposes its own class constants and resolution is timedelta(microseconds=1) rather than timedelta(days=1). Also add ClassVar annotations for date and datetime class constants.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define datetime.min, datetime.max, and datetime.resolution instead of
inheriting them from date. This aligns the API with the stdlib, where
datetime exposes its own class constants and resolution is
timedelta(microseconds=1) rather than timedelta(days=1).
Also add ClassVar annotations.