Remove default __time = None from datetime#187
Merged
Conversation
Setting __time to None makes type checkers infer that the attribute is optional, while in reality it is always initialized by __init__. Since __time is a private implementation detail, this change is not considered breaking.
slashmili
approved these changes
Jul 14, 2026
Owner
|
Thanks |
Owner
|
Released as 6.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
__timetoNonemakes type checkers infer that the attribute is optional, while in reality it is always initialized by__init__.Since
__timeis a private implementation detail, this change is not considered breaking.