fix: preserve instance locale in datetime.astimezone()#190
Open
patchwright wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
jdatetime.datetime.astimezone(tz)silently drops the instancelocaleand resets it to the global default.Expected
'fa_IR'. Confirmed onmainHEAD4b461d1.Root cause
astimezonerebuilds the result withdatetime.fromgregorian(datetime=gdt)and does not pass the instance locale (jdatetime/__init__.py:1176). Every sibling that round-trips throughfromgregorianpasses it:__add__(1009),__sub__(1022),replace(1002),combine(860).astimezoneis the only outlier.Fix
Pass
locale=self.locale, matching the siblings. One line, no API change.How to test
Added
test_astimezone_keeps_locale, next totest_replace_keeps_date_locale. It fails onmainwithAssertionError: 'en_US' != 'fa_IR'and passes with this change. Real output:The full suite is green apart from a pre-existing
test_with_fa_localethat fails withlocale.Error: unsupported locale settingon machines missing thefa_IR.UTF-8system locale. It fails identically on unpatchedmain, so it is unrelated to this change. A CHANGELOG entry is included.Backward compatibility
No breaking changes. After
astimezone, the instance locale is preserved, consistent withreplace,combine,__add__, and__sub__.Assisted-by: Claude (code generation, reviewed and tested locally)