feat: bundle FFmpeg + fix bundle.active (make release publish installers) - #14
Merged
Conversation
Recordings needed a system ffmpeg. Now a static ffmpeg binary is bundled inside
the app via Tauri externalBin ("bin/ffmpeg"), so there's no external dependency —
without committing ~45MB binaries to git.
- release.yml downloads the correct ffmpeg per target (eugeneware/ffmpeg-static)
into src-tauri/bin/ffmpeg-<triple> before tauri build.
- download:ffmpeg script now actually downloads the host binary for local builds.
- tauri.conf.json: externalBin ["bin/ffmpeg"]; also flipped bundle.active to true
(it was false, which would produce a release with NO installers).
- ffmpeg.rs already resolves bin/ffmpeg next to the executable — where Tauri
places the sidecar — so no Rust change; system ffmpeg stays the dev fallback.
- Docs updated (RELEASING-DESKTOP.md) incl. the GPL-build license note.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013dqouzFP8vy9jaKhTDFj5H
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
bundle.activewasfalse, so tauri-action reported "No artifacts were found" even though it built and signed the app. Set totrue.externalBin— CI (andnpm run download:ffmpeglocally) fetch a static ffmpeg per target intobin/ffmpeg-<triple>before build; nothing committed to git.Verified locally
tauri buildproducedGoodWebTools.appwith ffmpeg bundled atContents/MacOS/ffmpeg, and the bundled binary runs (ffmpeg 6.0). (The local.dmgstep hit a known macOSbundle_dmg.shquirk; CI builds DMGs fine.)Note
ffmpeg-staticships a GPL FFmpeg build — bundling it makes the distributed app GPL-encumbered (fine while GoodWebTools is open source). Documented in RELEASING-DESKTOP.md.🤖 Generated with Claude Code