fix(release): defer ffmpeg externalBin + fix deploy OOM - #16
Merged
Conversation
The externalBin ffmpeg sidecar is validated by tauri-build at COMPILE time, so it broke every workflow that compiles the crate (release + desktop-check) — the CI sidecar wasn't found at build time even though the download step ran. Rather than keep blocking the release, remove externalBin for now (keep bundle.active: true — the actual fix that makes tauri-action publish installers). The app falls back to system ffmpeg; proper bundling will return in a follow-up that fixes all compile-time workflows. Also fix the Cloudflare Pages deploy (deploy.yml): its `npm run build` OOM'd on the default ~2GB Node heap — added NODE_OPTIONS=--max-old-space-size=8192. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013dqouzFP8vy9jaKhTDFj5H
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
externalBin validates at compile time and broke release + desktop-check. Removed it (kept bundle.active:true); fixed Cloudflare deploy OOM with NODE_OPTIONS. 🤖 Generated with Claude Code