fix(maps): prevent blank tiles after GeolocateControl flyTo - #166
Merged
Conversation
Promote to production: fix map-explorer stack overflow on resize
Three root causes addressed: 1. Spurious setStyle: the re-style effect was calling map.setStyle() even when the resolved URL hadn't changed (e.g. 'auto'→'liberty' with light theme resolves to the same URL). MapLibre treats any setStyle call as a full style reload, cancelling in-flight tile requests. Added appliedStyleUrl ref to skip no-op calls. 2. triggerRepaint after moveend: map.resize() is a no-op when canvas dimensions haven't changed (container CSS doesn't change during flyTo), so it doesn't kick off tile fetching. Added map.triggerRepaint() after resize() to force a render cycle that discovers and requests missing tiles. 3. Explicit minZoom/maxZoom: avoids the MapLibre v6 circular 'get minZoom' getter bug (seen in the earlier stack overflow) by giving the transform concrete values instead of relying on the derived getter chain. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
goodwebtools | 63c72d3 | Aug 07 2026, 10:12 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
map.setStyle()even when the resolved style URL was unchanged (e.g. switching between'auto'and'liberty'with a light theme resolves to the same OpenFreeMap URL). MapLibre treats anysetStylecall—even with the same URL—as a full style reload, cancelling all in-flight tile requests. AddedappliedStyleUrlref to skip no-op calls.flyToends,map.resize()is a no-op when the canvas dimensions haven't changed (the container CSS is fixed). Without an explicit repaint, MapLibre's tile-fetch cycle never runs for the new viewport. Addedmap.triggerRepaint()afterresize()in themoveendrAF handler.minZoom: 0, maxZoom: 20to theMapconstructor to avoid the MapLibre v6 circularget minZoomgetter (which caused the earlier stack overflow) from corrupting the transform at high zoom levels.Test plan
🤖 Generated with Claude Code