Promote to production: robust QR/QRIS camera-photo decoding - #219
Merged
Conversation
…izes jsQR is unreliable on full-resolution phone photos (e.g. a 12MP shot of a QRIS standee), so detection failed. New shared decodeQrFromFile retries the decode at several downscaled sizes with inversion attempts, which decodes real-world photos with glare and angle. Wired into QRIS Decoder and QR Code Reader.
jsQR alone fails on real camera photos of QR/QRIS codes (glare, angle, small code in a big frame). New decode pipeline: native BarcodeDetector first (fast on Android/Chrome), then zxing-wasm with tryHarder (robust on every browser incl. iOS Safari; wasm served same-origin from /zxing_reader.wasm), then jsQR multi-scale as a fallback. Verified: a user's QRIS standee photo now decodes end-to-end.
fix(qr): decode QR/QRIS from large photos (downscale + retry)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the QR decode overhaul: BarcodeDetector + zxing-wasm (tryHarder) + jsQR fallback, so QRIS Decoder and QR Code Reader reliably read real camera photos.