fix(theme) + docs: dark-mode persistence, merged DEPLOYMENT, GA env clarity - #34
Merged
Conversation
slaveofcode
commented
Jul 26, 2026
slaveofcode
commented
Owner
- fix(theme): dark mode no longer resets on View Transitions navigation (re-apply on astro:after-swap).
- docs: merge DEPLOYMENT-GIT into one improved DEPLOYMENT.md; drop PUBLIC_GA_ID from .env.example (SITE_GA_ID is the single build-var knob).
added 3 commits
July 26, 2026 23:11
Dark mode reset to light when navigating between pages: the inline theme script ran only on initial load, so after a <ViewTransitions> swap the runtime 'dark' class was lost when the incoming (light) static page swapped in. Re-apply the stored theme on astro:after-swap (before paint, no flash).
Consolidate the two deploy docs; modernize the env-var section (SITE_GA_ID build var + branch-based auto-gating, split prod/staging R2 buckets, sync:r2 scripts). Remove DEPLOYMENT-GIT.md; fix the wrangler.jsonc reference.
… a build var Reduces confusion: one GA knob (SITE_GA_ID, set as a production BUILD variable on Cloudflare). PUBLIC_GA_ID remains internal plumbing (astro.config sets it from SITE_GA_ID on main builds).
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
goodwebtools | 84daf58 | Jul 26 2026, 04:26 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.