Skip to content

feat(desktop): bundle ffmpeg as a sidecar #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slaveofcode merged 1 commit into from
Jul 26, 2026
Merged

feat(desktop): bundle ffmpeg as a sidecar #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/desktop-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,16 @@ jobs:
mkdir -p dist
echo '<!doctype html><title>stub</title>' > dist/index.html

# externalBin ("bin/ffmpeg") is validated at compile time by tauri-build;
# an empty file is enough for `cargo check` — we never execute it here.
- name: Stub ffmpeg sidecar
shell: bash
run: |
mkdir -p src-tauri/bin
TRIPLE=$(rustc -vV | sed -n 's/host: //p')
EXT=""; [ "${{ runner.os }}" = "Windows" ] && EXT=".exe"
: > "src-tauri/bin/ffmpeg-${TRIPLE}${EXT}"

- name: cargo check (all targets)
working-directory: src-tauri
run: cargo check --all-targets
4 changes: 3 additions & 1 deletion src-tauri/tauri.conf.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"version": "1.0.0-beta.2",
"identifier": "com.goodwebtools.app",
"build": {
"beforeBuildCommand": "npm run build",
"beforeDevCommand": "npm run download:ffmpeg",
"beforeBuildCommand": "npm run download:ffmpeg && npm run build",
"frontendDist": "../dist",
"devUrl": "http://localhost:4321"
},
Expand Down Expand Up @@ -78,6 +79,7 @@
"bundle": {
"active": true,
"createUpdaterArtifacts": true,
"externalBin": ["bin/ffmpeg"],
"targets": ["nsis", "app", "dmg", "deb"],
"resources": [],
"category": "Utility",
Expand Down
Loading